Custom modal aux click #6891
Custom modal aux click #6891
Conversation
| .pipe( | ||
| skipUntil(timer(250)) // prevent closing immediately after modal open. | ||
| ) | ||
| .subscribe((event) => { |
There was a problem hiding this comment.
As I understand, the previous version of the code was executing immediately in some browsers (but apparently not in all of them), causing the event handler to be attached right before the "mouse up" event, or something like this, causing it to close it.
Can we instead check the type of event? Or something like this, to only match clicks? If an alternative solution is more complex, or difficult to validate, or if what I'm saying is not accurate or something, I'm ok with this solution. Just thought I'd ask.
There was a problem hiding this comment.
Oh this is better! I hadn't realized that there are two separate events for "right clicking": contextmenu (immediately triggers the system context menu) and auxclick (triggers when mousedown and mouseup occurs in the same element)
Since we're using contextmenu to open the modal, I updated the code to simply ignore the auxclick events, which should have the effect of ignoring the right click mouseup. To close the modal, left clicks and contextmenu events can still be used.
## Motivation for features / changes On some browsers, the [custom modal close](https://github.com/tensorflow/tensorboard/blob/0627ad5480b309a5f3f69f39e52670496c2e5863/tensorboard/webapp/widgets/custom_modal/custom_modal.ts#L116) logic will be triggered immediately after releasing the right click button, which causes the modal to be closed as soon as it is opened. ## Technical description of changes The modal close event handler will ignore the `auxclick` (right click) mouseup event. Modals can still be closed with left clicks and the `contextmenu` event. ## Screenshots of UI changes (or N/A) Status quo: 
## Motivation for features / changes On some browsers, the [custom modal close](https://github.com/tensorflow/tensorboard/blob/0627ad5480b309a5f3f69f39e52670496c2e5863/tensorboard/webapp/widgets/custom_modal/custom_modal.ts#L116) logic will be triggered immediately after releasing the right click button, which causes the modal to be closed as soon as it is opened. ## Technical description of changes The modal close event handler will ignore the `auxclick` (right click) mouseup event. Modals can still be closed with left clicks and the `contextmenu` event. ## Screenshots of UI changes (or N/A) Status quo: 
Motivation for features / changes
On some browsers, the custom modal close logic will be triggered immediately after releasing the right click button, which causes the modal to be closed as soon as it is opened.
Technical description of changes
The modal close event handler will ignore the
auxclick(right click) mouseup event. Modals can still be closed with left clicks and thecontextmenuevent.Screenshots of UI changes (or N/A)
Status quo: